Version 1.8.3

## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.3`.

💥 Softlock/Crash fixes 💥

• Fixed AI bug that caused an infinite loop when player mon has only status moves by @Pawkkie and @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4403
• Temporarely disabled AI_FLAG_SMART_MON_CHOICES flag in double battles to prevent a softlock by @Sneed69 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4405
• Fixed debug option "Fill PC Boxes Fast" softlocking the game by @mrgriffin in https://github.com/rh-hideout/pokeemerald-expansion/pull/4428
• Fixed infinite loop caused by Leftovers with AI_FLAG_SMART_MON_CHOICES by @Pokabbie and @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4453

🧬 General 🧬

Changed

• Updated outdated macOS instructions in INSTALL.md by @jschoeny in https://github.com/rh-hideout/pokeemerald-expansion/pull/4407
• Made filepath links in README.md relative by @lolbinarycat in https://github.com/rh-hideout/pokeemerald-expansion/pull/4509

Fixed

• Fixed abilities not being properly inherited via breeding for species/abilities with IDs over 255 by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4411
• Fixed Hard Level Caps issues by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4420
  • Fixed Pokémon being able to surpass cap if they gained enough experience at once.
  • Fixed Exp. Candies ignoring hard caps.
  • Fixed Pokémon gaining 1 experience if they are at the level cap.
• Fixed evolution tracker issues by @cawtds in https://github.com/rh-hideout/pokeemerald-expansion/pull/4503
  • EVO_LEVEL_MOVE_TWENTY_TIMES no longer increases with every move.
  • EVO_LEVEL_RECOIL_DAMAGE_MALE/FEMALE is no longer updated twice than intended.

✨ Feature Branches ✨

TheXaman's HGSS Pokédex Plus:

Fixed

• Fixed Pokémon data page not properly handling u16 Exp. Yields by @Sneed69 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4432
  • Cleanup by @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4445

🐉 Pokémon 🐉

Changed

• Further Gen 9 Pokémon icon improvements by @kittenchilly in https://github.com/rh-hideout/pokeemerald-expansion/pull/4413
  • Original sprites by ezerart on DeviantArt. Palette assignments and 2nd frames by kittenchilly.
  • Cyclizar, Dipplin, Farigiraf, Glimmet, Glimmora, Greavard, Iron Moth, Revavroom, Tadbulb, Paldean Tauros (all three of them), Tinkaton and Paldean Wooper.
• Further Gen 9 Pokémon front/back sprite improvements by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4414
  • Source: PokéCommunity
  • Dolliv, Arboliva, Charcadet, Mabosstiff, Tinkatink, Tinkatuff, Tinkaton and Chien-Pao.

Fixed

• Fixed Lycanroc Dusk and Midnight forms using Midday's backsprite by @Eemeliri in https://github.com/rh-hideout/pokeemerald-expansion/pull/4430
• Fixed Tatsugiri Droopy back sprite palette by @cafei-uh in https://github.com/rh-hideout/pokeemerald-expansion/pull/4455

⚔️ Battle General ⚔️

Changed

• Turned B_RESTORE_HELD_BATTLE_ITEMS into a generational config by @LOuroboros in https://github.com/rh-hideout/pokeemerald-expansion/pull/4402

Fixed

• Fixed battle Partner trainer class and potential OOB-related issues by @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4422

🤹 Moves 🤹

Fixed

• Fixed Quash not properly working when B_RECALC_TURN_AFTER_ACTIONS is set to GEN_8 or greater by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4419
• Fixed Will-O-Wisp's name capitalization in gMovesInfo by @LOuroboros in https://github.com/rh-hideout/pokeemerald-expansion/pull/4425
• Fixed Thunder Cage not printing the right battle message by @Sneed69 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4426
• Fixed Diamond Storm missing its effect by @PhallenTree in https://github.com/rh-hideout/pokeemerald-expansion/pull/4489
• Fixed Mortal Spin's description by @PhallenTree in https://github.com/rh-hideout/pokeemerald-expansion/pull/4489
• Fixed Assist being able to call MOVE_NONE by @PhallenTree in https://github.com/rh-hideout/pokeemerald-expansion/pull/4491

🎭 Abilities 🎭

Changed

• Changed the Embody Aspect defines to use the full form name, to be in line with the species define by @kittenchilly in https://github.com/rh-hideout/pokeemerald-expansion/pull/4439
  • Eg. ABILITY_EMBODY_ASPECT_TEAL -> ABILITY_EMBODY_ASPECT_TEAL_MASK.

Fixed

• Fixed Intimidate/Supersweet Syrup playing their animation and not printing the right message for battlers at -6 stage Attack/Evasion by @Sneed69 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4406
• Fixed ability pop ups not respecting abilityPopupOverwrite in tests by @kittenchilly in https://github.com/rh-hideout/pokeemerald-expansion/pull/4423
• Fixed Dancer copying multi-target moves by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4437
• Fixed Hospitality triggering on a fainted mon by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4450
• Fixed Embody Aspect (Teal Mask) boosting Sp. Attack instead of Speed by @kittenchilly in https://github.com/rh-hideout/pokeemerald-expansion/pull/4439
• Fixed lingering long ability popup names by @Sneed69 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4456
• Fixed Fur Coat not being skipped by Mold Breaker abilities by @Bassoonian in https://github.com/rh-hideout/pokeemerald-expansion/pull/4459
• Fixed Color change not being triggered by Future Sight or Doom Desire by @AlexOn1ine and @hedara90 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4472
• Fixes Magic Bounce only working for battlers in certain positions by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4464
• Fixed Costar, Zero to Hero, Supreme Overlord and Ruin abilities' switch-in battle messages showing sometimes incorrectly by @PhallenTree in https://github.com/rh-hideout/pokeemerald-expansion/pull/4500
  • Cleanup by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4511

🧶 Items 🧶

Fixed

• Fixed typo in Rotom Catalogue description by @mrgriffin in https://github.com/rh-hideout/pokeemerald-expansion/pull/4433
• Eject item fixes (Eject Button/Pack):
  • Fixed regression from 1.8.2 that caused Eject Pack to not trigger upon self-inflicted stat decreases by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4463
  • Fixed Eject Items causing wrong Pokémon taking damage by entry hazards by @PhallenTree in https://github.com/rh-hideout/pokeemerald-expansion/pull/4465
  • Cleanup by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4497
• Fixed Flute Items being consumed in battle by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4496
• Fixed Red Card activating if the holder was switched in in the same turn (eg. via Endure) by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4482

🤖 Battle AI 🤖

Changed

• AI_FLAG_SMART_SWITCHING flag now automatically sets AI_FLAG_SMART_MON_CHOICES as well by @Sneed69 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4405
  • Cleanup by @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/pull/4409
• Corrected IsDamageMoveUsable's name to IsDamageMoveUnusable by @WillKolada in https://github.com/rh-hideout/pokeemerald-expansion/pull/4476
• Fixed AI not knowing that Steam Roller fails when there's no terrain by @WillKolada in https://github.com/rh-hideout/pokeemerald-expansion/pull/4476
  • Cleanup by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4498

🧪 Test Runner 🧪

Added

• Added missing Color change tests by @hedara90 in https://github.com/rh-hideout/pokeemerald-expansion/pull/4472

Changed

Fixed

• Fixed AI test error messages by @mrgriffin in https://github.com/rh-hideout/pokeemerald-expansion/pull/4404
  • The error messages for EXPECT_MOVE and EXPECT_SWITCH were backwards, saying, e.g. Expected MOVE, got SWITCH when it should say Expected SWITCH, got MOVE.
• Fixed typos in Embody Aspect tests by @kittenchilly in https://github.com/rh-hideout/pokeemerald-expansion/pull/4439
• Fixed Battle Test organization by @AsparagusEduardo in https://github.com/rh-hideout/pokeemerald-expansion/pull/4504
  • Fixed Cud Chew's file being in the move effect folder.
  • Fixed Cud Chew's file name and test names (Cud Chuw).
  • Fixed Gastro Acid and Role Play's files being in the ability folder.
  • Moved Recoil file to move flags folder.
  • Renamed White Herb's file to restore_stats.c.
  • Renamed Techno Blast's file to change_type_on_item.c.
  • semi_invulnerable_moves.c to semi_invulnerable.c.
  • two_turn_moves.c to two_turns_attack.c.
  • Combined Burn Up/Double Shock to a single file fail_if_not_arg_type.c
  • Added Spit Up/Swallow files that point Stockpile's file.
  • Moved secondary effect files to their own folder.
  • Combinations of secondary effects moved to their own folder
  • Split hit_set_entry_hazards.c to separate files for Spikes/Stealth Rock.
  • Grouped Hex/Venoshock to the same file double_power_on_arg_status.c

New Contributors

• @jschoeny made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4407
• @Eemeliri made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4430
• @cafei-uh made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4455
• @PhallenTree made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4465
• @WillKolada made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4476
• @cawtds made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4503
• @lolbinarycat made their first contribution in https://github.com/rh-hideout/pokeemerald-expansion/pull/4509

Full Changelog: https://github.com/rh-hideout/pokeemerald-expansion/compare/expansion/1.8.2...expansion/1.8.3